Bug #4294

3.4.2 breaks theme_advanced_containers

Submitted:
2011-04-11 14:26:41 By: tan
Browsers:
firefox msie safari chrome opera
Open Priority: 3 Resolution: None Assigned to: spocke
I see that something related to this was fixed in this commit (just before the release):

https://github.com/tinymce/tinymce/commit/d787102158a93d105c9375ddafa6866207ca1fae

If I change back to the previous revision my theme_advanced_containers configuration works again.

Description of problem:

Steps to reproduce:
1.
2.
3.
4.
5.

Expected result:

Actual result:

 

If you wish to follow or post a comment, you need to be registered and logged in.

Comments

User Image
  • 2011-04-11 14:54:32

alec

theme_advanced_containers : 'row1,row2,row3,editorcontainer,statusbarcontainer',
theme_advanced_container_editorcontainer : 'mceEditor',
theme_advanced_container_statusbarcontainer : 'mceElementpath',

Change your config to theme_advanced_containers : 'row1,row2,row3,mceEditor,mceElementPath',

User Image
  • 2011-04-11 15:36:07

alec

So, to make this working as documented here http://tinymce.moxiecode.com/wiki.php/Configuration:theme_advanced_container_container. The commit specified in the ticket szhould be reverted. However, we could improve this to support both syntax cases.

BTW, I've found related issue. Consider theme_advanced_containers : 'row1,row2,row3', where non of containers is the mceEditor. In that case js error is thrown "d is undefined" in line 10927 of tiny_mce.js (tinymce.Editor.setupIframe function).

User Image
  • 2011-04-11 17:19:15

tan

@alec: It seems to work when I update my configurations with your suggestion, but I guess it will break other integrations out there which uses this functionality.

Support for both syntaxes sound like an good idea (mark the old syntax as deprecated for example)

User Image
  • 2011-06-20 23:07:00

spocke

Could you provide me with an example that breaks and used to work so I can verify that we fix this one correctly?

Thanks

User Image
  • 2011-06-21 07:27:39

alec

You've got it in my first comment. First three lines are from old config (not work now). The last line works now. Also take a look at the issue described in my second comment.

User Image
  • 2012-04-04 07:27:14

alec

Here you are , some combinations that throw errors:
http://fiddle.tinymce.com/Inbaab/1
http://fiddle.tinymce.com/Inbaab/2
http://fiddle.tinymce.com/Inbaab/3
http://fiddle.tinymce.com/Inbaab/4
http://fiddle.tinymce.com/Inbaab/5