1 Topic by spocke

  • spocke
  • Administrator
  • Offline
  • From: Sweden, Skellefteå
  • Registered: 2004-11-25
  • Posts: 14,345

Topic: TinyMCE 3.0.7 Released

This release mainly fixes bugs and other small issues but it has one new feature that will generate version unique URLs for all the parts of the editor this to avoid issues where the user hasn't cleared the cache and reports a bug to us or some third party system like Wordpress etc. So all .js files, .html and .css files will be suffixed with ?v=307 to produce version unique URLs. This will hopefully reduce pointless bug reports that can be avoided with a simple browser clear cache call.

We also added a new table selection feature. This enables you to more easily select whole tables by simply clicking on it's border. It will make it easier to delete the table or add classes to it. This was also added to normalize the browser behavior.

We also fixed a new type of memory leak in IE that we blogged about at this page:
http://blog.moxiecode.com/2008/04/08/un … res-in-ie/

Change log:
Added new version suffix to all internal GET requests to make sure that the users cache gets cleared correctly.
Fixed issue with isDirty returning true event if it wasn't dirty on IE due to changes in tables during initialization.
Fixed memory leak in IE where if a page was unloaded before all images on the page was loaded it would leak.
Fixed bug in IE where underline and strikethrough could produce an exception error message.
Fixed bug where inserting paragraphs in totally empty table cells would produce odd effects.
Fixed bug where layer style data wasn't updated correctly due to some performance enhancements with the DOM serializer.
Fixed bug where it would convert the wrong element if there was two elements with the same name and id on the page.
Fixed bug where it was possible to add style information to the body element using the style plugin.
Fixed bug where Gecko would add an extra undo level some times due to the blur event.
Fixed bug where the underline icon would get active if the caret was inside a link element.
Fixed bug where merging th cells not working correctly. Patch contributed by André R.
Fixed bug where forecolorpicker and backcolorpicker buttons where rendered incorrectly when the o2k7 skin was used.
Fixed bug where comment couldn't contain -- since it's invalid markup. It will now at least not break on those invalid comments.
Fixed bug where apos wasn't handled correctly in IE. It will now convert apos to " on IE since that browser doesn't support that entity.
Fixed bug where entities wasn't encoded correctly inside pre elements since they where protected from whitespace removal.
Fixed bug where color split buttons where rendered incorrectly on IE6 when using the non default theme.
Fixed so caret is placed after links ones they are created, to improve usability of the editor.
Fixed so you can select tables by clicking on it's borders in non IE browsers to normalize the behavior.
Fixed so the menus can be toggled by clicking once more on the icon in listboxes, menubuttons and splitbuttons based on code contributed by Josh Peek.
Fixed so buttons can be labeled, currently only works with the default skin, so it's kind of experimental. Patch contributed by Daniel Insley.
Fixed so forecolorpicker and backcolorpicker remembers the last selected color. Patch contributed by Shane Tomlinson.
Fixed so that you can only execute the mceAddEditor command once for the same instance name.
Fixed so command functions added with addCommand can pass though the call to default handles if it returns true.

Best regards,
Spocke - Main developer of TinyMCE

spocke's Website

2 Reply by laura8

  • laura8
  • Member
  • Offline
  • Registered: 2008-03-05
  • Posts: 17

Re: TinyMCE 3.0.7 Released

hi Spocke, thx for new release, I was trying it out, by I get a JS error, line 2, char 12941, Invalid Argument, ehm .. could you pls check that, thx.

3 Reply by spocke

  • spocke
  • Administrator
  • Offline
  • From: Sweden, Skellefteå
  • Registered: 2004-11-25
  • Posts: 14,345

Re: TinyMCE 3.0.7 Released

I need more info that that. Steps to reproduce?

Best regards,
Spocke - Main developer of TinyMCE

spocke's Website

4 Reply by laura8

  • laura8
  • Member
  • Offline
  • Registered: 2008-03-05
  • Posts: 17

Re: TinyMCE 3.0.7 Released

1. unpack tiny_mce folder
2. usual HTML file which I use to test tinyMCE, containing only tinyMCE itself and a form with a textare
3. the simplest configuration (either "advanced" or "simple" theme), IE 6.0
tinyMCE.init({
  mode : "textareas",
  theme : "advanced",
  width : "100%"
});

5 Reply by laura8

  • laura8
  • Member
  • Offline
  • Registered: 2008-03-05
  • Posts: 17

Re: TinyMCE 3.0.7 Released

I found out the piece of code that causes the problem:
tinyMCE 3.0.6.2 (ok):
  v.id = v.id || v.name;
tinyMCE 3.0.7 (nok, substituted above with):
  // Can we use the name
  e = DOM.get(v.name);
  if (!v.id && !e)
    v.id = v.name;

by reverting this piece of code back, I don't get the error anymore.
don't really know how it works here, I just did a comparison ..

6 Reply by spocke

  • spocke
  • Administrator
  • Offline
  • From: Sweden, Skellefteå
  • Registered: 2004-11-25
  • Posts: 14,345

Re: TinyMCE 3.0.7 Released

Could you post a link or the whole HTML chunk. Since that code is used to replace textareas with instances. And I guess it might fail then if the HTML is odd in some way.

Best regards,
Spocke - Main developer of TinyMCE

spocke's Website

7 Reply by laura8

  • laura8
  • Member
  • Offline
  • Registered: 2008-03-05
  • Posts: 17

Re: TinyMCE 3.0.7 Released

could it be related to testing on a network machine (remote) ?

8 Reply by prwood

  • prwood
  • Member
  • Offline
  • Registered: 2006-10-26
  • Posts: 4

Re: TinyMCE 3.0.7 Released

Was just noticing that this bug I submitted has been passed over for 3.0.6 and 3.0.7. Any chance it could be addressed in the next bugfix release?

https://sourceforge.net/tracker/?func=d … tid=635682

9 Reply by laura8

  • laura8
  • Member
  • Offline
  • Registered: 2008-03-05
  • Posts: 17

Re: TinyMCE 3.0.7 Released

posted a new bug with attached the html I'm using
http://sourceforge.net/tracker/index.ph … tid=635682

10 Reply by stingbat

  • stingbat
  • Member
  • Offline
  • Registered: 2008-01-11
  • Posts: 7

Re: TinyMCE 3.0.7 Released

Probably happens due to the missing name-attribute (like <textarea name="blabla" ...>).

11 Reply by spocke

  • spocke
  • Administrator
  • Offline
  • From: Sweden, Skellefteå
  • Registered: 2004-11-25
  • Posts: 14,345

Re: TinyMCE 3.0.7 Released

@laura8: The bug is now resolved in the SVN trunk. It only happens on IE and only when the textareas look like this <textarea id="xyz">. Will be included in the next release.
@prwood: Fixed in SVN as well.
@stingbat: Yep. smile

Best regards,
Spocke - Main developer of TinyMCE

spocke's Website

12 Reply by stingbat

  • stingbat
  • Member
  • Offline
  • Registered: 2008-01-11
  • Posts: 7

Re: TinyMCE 3.0.7 Released

Just saw the change in the SVN about the ... Could probably be cleaned down to (also easier to add other tags if needed later-on):
o.content = o.content.replace(/^(<p>( | |\s|\u00a0|)<\/p>|<br \/>)[\r\n]*$/, '');

SVN: http://tinymce.svn.sourceforge.net/view … amp;r2=805

Minor thing of course, but hey smile hehe

Last edited by stingbat (2008-04-14 21:20:09)

13 Reply by hyperrun

  • hyperrun
  • Member
  • Offline
  • Registered: 2008-04-15
  • Posts: 1

Re: TinyMCE 3.0.7 Released

Fullscreen mode is not working anymore, i replace the new 'tiny_mce.js' to be able to use the fullscreen mode on Safari.
And it seems that some languages are not working on the plugins (ex: advimage, advattributes, ... and many others)

Languages and popup trouble solution:

line 104 of tiny_mce_popup.js => on the new file the line is like this:

   document.write('<script type="text/javascript" src="' + tinymce._addVer(u) + '"></script>');

if the line is changed as below everything will work:

   document.write('<script type="text/javascript" src="' + u + '"></script>');


Tested on Safari, Ie (various version from 5 to 7), Opera (mac & Linux), Firefox (on mac, windows & Linux)

Last edited by hyperrun (2008-04-15 11:44:26)

14 Reply by spocke

  • spocke
  • Administrator
  • Offline
  • From: Sweden, Skellefteå
  • Registered: 2004-11-25
  • Posts: 14,345

Re: TinyMCE 3.0.7 Released

Works fine for me in all browsers when I try the example: http://tinymce.moxiecode.com/example_fu … ample=true

Best regards,
Spocke - Main developer of TinyMCE

spocke's Website

15 Reply by laura8

  • laura8
  • Member
  • Offline
  • Registered: 2008-03-05
  • Posts: 17

Re: TinyMCE 3.0.7 Released

spocke wrote:

@laura8: The bug is now resolved in the SVN trunk. It only happens on IE and only when the textareas look like this <textarea id="xyz">. Will be included in the next release.
@prwood: Fixed in SVN as well.
@stingbat: Yep. smile

thx for the fix, indeed it doesn't make much sense not to have a name attribute on textareas, it's just that I use a very simple HTML to test features of newly published tinyMCE, maybe a bit too simple HTML actually smile

whereas I still have the icons' problem when I try editor_css pointing to a css file outside original folder, as per
http://sourceforge.net/tracker/index.ph … tid=635682
this actually isn't really a "mega-issue", it just needs to copy the needed icons.gif (and possibly buttons.png and company) and point to them correctly within own ui.css file, and the problem is solved.
In the end, I don't kwow if this may be considered a bug at all ..

regarding fullscreen problem, some time ago I posted following
http://sourceforge.net/tracker/index.ph … tid=635682
there seemed to be a problem with fullscreen_new_window option

Last edited by laura8 (2008-04-15 12:08:47)

16 Reply by Ivor Humphreys

  • Ivor Humphreys
  • Member
  • Offline
  • Registered: 2008-03-16
  • Posts: 24

Re: TinyMCE 3.0.7 Released

Been meaning to mention this for a while:

langs/en.js

advhr_desc:"Horizontale rule"

advhr_desc:"Horizontal rule" (no 'e' in Horizontal)

Thanks for such great software.

Ivor H

Also "Inserts new table" button tool-tip would better as "Insert/modify table"

Last edited by Ivor Humphreys (2008-04-16 14:06:21)

17 Reply by lkeijmel

  • lkeijmel
  • Member
  • Offline
  • From: The Netherlands
  • Registered: 2008-03-13
  • Posts: 117

Re: TinyMCE 3.0.7 Released

moved to http://tinymce.moxiecode.com/punbb/view … ?pid=35722

Last edited by lkeijmel (2008-04-15 16:57:48)

Grtz, Laurence

18 Reply by craig.raymond

  • craig.raymond
  • Member
  • Offline
  • Registered: 2005-09-13
  • Posts: 22

Re: TinyMCE 3.0.7 Released

I'm wondering what replaces tinyMCE.regexpReplace()?

And I suppose, do I need it to do the  following anymore?

function cleanupBeforeSave(element_id, html, body) {
    workHtml = html;

    if (workHtml.indexOf('cursor: pointer; cursor: hand') < 1) {
        // msie strips 'cursor: pointer'
        if (workHtml.indexOf('cursor: hand') > 0) {
            workHtml = tinyMCE.regexpReplace(workHtml, 'cursor: hand', 'cursor: pointer; cursor: hand', 'gi');

        // gecko strips 'cursor: hand'
        } else if (workHtml.indexOf('cursor: pointer') > 0) {
            workHtml = tinyMCE.regexpReplace(workHtml, 'cursor: pointer', 'cursor: pointer; cursor: hand', 'gi');
        }
    }
    return workHtml;
}

Last edited by craig.raymond (2008-04-15 18:59:08)

19 Reply by spocke

  • spocke
  • Administrator
  • Offline
  • From: Sweden, Skellefteå
  • Registered: 2004-11-25
  • Posts: 14,345

Re: TinyMCE 3.0.7 Released

string.replace(/pattern/, 'replacement') is the same thing. So it was redundant in the first place. Don't know why I added it.

Best regards,
Spocke - Main developer of TinyMCE

spocke's Website

20 Reply by cosmin2

  • cosmin2
  • Member
  • Offline
  • Registered: 2008-02-25
  • Posts: 12

Re: TinyMCE 3.0.7 Released

Hello.

I am (still) using the Drupal implementation of TinyMCE; I updated to 3.0.7 and I have a strange behavior, the labels of the control get messed-up, when trying to edit a link. For instance, instead of "General properties" label of a static I get {#advlink_dlg.general_props}.

Any idea ?

Cosmin

Last edited by cosmin2 (2008-04-16 19:55:31)

21 Reply by spocke

  • spocke
  • Administrator
  • Offline
  • From: Sweden, Skellefteå
  • Registered: 2004-11-25
  • Posts: 14,345

Re: TinyMCE 3.0.7 Released

What does Firebug say. What is the error message?

Best regards,
Spocke - Main developer of TinyMCE

spocke's Website

22 Reply by cosmin2

  • cosmin2
  • Member
  • Offline
  • Registered: 2008-02-25
  • Posts: 12

Re: TinyMCE 3.0.7 Released

tinymce.ScriptLoader.isDone is not a function, in tiny_mce_popup.js (line 103)

23 Reply by spocke

  • spocke
  • Administrator
  • Offline
  • From: Sweden, Skellefteå
  • Registered: 2004-11-25
  • Posts: 14,345

Re: TinyMCE 3.0.7 Released

Clear your browser cache and try again.

Best regards,
Spocke - Main developer of TinyMCE

spocke's Website

24 Reply by cosmin2

  • cosmin2
  • Member
  • Offline
  • Registered: 2008-02-25
  • Posts: 12

Re: TinyMCE 3.0.7 Released

The labels of all controls are correct now, so thank you for your suggestion.

Firebug shows another error:

[Exception... "'Permission denied to get property XULElement.accessible' when calling method: [nsIAccessibleProvider::accessible]" nsresult: "0x8057001e (NS_ERROR_XPC_JS_THREW_STRING)" location: "JS frame :: http://www.casa-romanilor.ch/modules/ti … s.js?v=307 :: selectByValue :: line 79" data: no]

25 Reply by spocke

  • spocke
  • Administrator
  • Offline
  • From: Sweden, Skellefteå
  • Registered: 2004-11-25
  • Posts: 14,345

Re: TinyMCE 3.0.7 Released

Hmm, never seen that. But XUL related exceptions like that might be some Firefox extension acting up. What FF version are you using, can the error be reproduce on this sites example pages?

Best regards,
Spocke - Main developer of TinyMCE

spocke's Website