26

Re: TinyMCE 3.2.3 Released

spocke wrote:

Yes, it removed all formatting. Since the user might have times new roman or other non web friendly text styles. However we have been thinking of adding some form of option to keep some of these formatting rules intact. Such as color, font styling etc.

Yes, adding this feature would be most appreciated. Unfortunately I think we may not be able to upgrade to this release w/o that capability.

Rick Meyer
http://rameyer.gather.com

27

Re: TinyMCE 3.2.3 Released

Hi cguthri,

don't forget: Offering event handlers in the HTML code opens the door for XSS attacks. Event handlers can contain malicious code or load malicious code into the document... So why offer this anyway?

Greetings from Germany,

Felix Riesterer.
(-> about me and this forum <-)

28

Re: TinyMCE 3.2.3 Released

@cguthri: Input elements works as before they have also been verified to work the exact same way using the unit tests. I also verified them manually now since you mentioned it. Same goes for onclick, unable to reproduce your behavior. Tested on FF 3, IE 6, IE 8.

@GatherRick: The older versions didn't keep styles like color either so the new release is no different from the old one in that regard.

Best regards,
Spocke - Main developer of TinyMCE

29

Re: TinyMCE 3.2.3 Released

@Felix - XSS are not a concern in my case.  The general public is not posting any content, only clients of ours wishing to edit their website content.  Just saying, "why offer this", instead of looking into the issue or debating if the existence of the issue is not productive and not appreciated.  The issue of the mouse events being rendered inactive by the the additional function definition only happens with IE 6 and 7 and sounds like a bug and not a security feature.  If you are not willing to help then at least tell me where specifically I might look in the code to prevent this from happening.  I have looked everywhere and cannot find it.

@spoke - It strange you are not experiencing the same issue.  I can go to the example and reproduce the issue: http://tinymce.moxiecode.com/examples/full.php

If I use the html:

<p><input onclick="alert('test');" type="button" value="Test" /></p>

then in FF it works fine, but in IE 8 it just removes the input element completely.

also:

<a href="#" onclick="alert('onclick');">test</a>

In IE7 it turns that into:

<p><a onclick="function onclick() { function onclick() { alert('onclick'); } }" href="#">test</a></p>

Also, javascript code can now get mangled in a way that causes infinite loops.  For example:

for(i=10;i>0;i--)

becomes

for(i=10;i>0;i)

the minuses are removed.  I believe this is related to what ever process is automatically adding the comment tags inside of the all script blocks.

30

Re: TinyMCE 3.2.3 Released

I managed to reproduce the input problem now. It's because it's inside the paragraph element. I only tested it on paragraph with other contents in it not in an empty one. Anyway, I know why this is happening we added a fix to the latest version for removing redundant contents in empty paragraphs on IE. For example <p><span><strong></strong></span></p> will become <p></p> but this logic is failing to detect the input elements as valid content elements. I will add a fix for this for the next release.

However the the event issue could not be reproduced.

And the final issue could be reproduced but please file a bug report on it an we will look at it when we get the time.

Best regards,
Spocke - Main developer of TinyMCE

31

Re: TinyMCE 3.2.3 Released

Excellent, spocke, thank you so much!  I'll go ahead and add the final issue to the bug site as you asked.  I also have some plugins to post as well.  I made a series of plugins to add and edit input elements.

On the event issue, the problem started with a client using IE7, but I was able to reproduce it with IE8 running in compatibility mode.  Perhaps you could try reproducing the error on IE8 in compatibility mode as well.

32

Re: TinyMCE 3.2.3 Released

I managed to find and fix the event issue as well. I only tested it on IE 6 and IE 8 in standards mode and they both worked fine. IE 7 and IE 8 in standards mode was producing a wrapper function. So you don't need to report the bug.

Best regards,
Spocke - Main developer of TinyMCE

33

Re: TinyMCE 3.2.3 Released

Any chance I could get ahold of the fixes now before the next release, or point me in the right direction to fix it now?

And do you still want me to bug report the "disappearing minuses in javascript code" issue?

34

Re: TinyMCE 3.2.3 Released

You can grab the SVN version from Sourceforge. Yes, please make a report of the missing -- signs.

Best regards,
Spocke - Main developer of TinyMCE

35

Re: TinyMCE 3.2.3 Released

I haven't looked at the new paste plugin in action yet (just had a brief scan of the patch), but I am a little concerned that some of the options I rely on are no longer supported.  Wouldn't it have been better to call the new plugin say paste2 with similar name changes to the buttons?  This would not preclude deprecating the old paste plugin, and would have given us the opportunity to more gracefully transition from one to the other.

I have existing uses that rely on paste_remove_spans, paste_remove_styles and paste_strip_class_attributes.  While I am unlikely to have time to get to this for a while, will you be receptive to patches to restore such options?

Scott

(a.k.a. monkeybrain)

36

Re: TinyMCE 3.2.3 Released

We didn't want to support the old paste plugin since it had some issues with Word 2007 that didn't exist when we created it. So we just removed the old one and replaced it with the new one. It's still missing some options and features that the old one had, we will look into adding them over time.

Best regards,
Spocke - Main developer of TinyMCE

37

Re: TinyMCE 3.2.3 Released

spocke wrote:

@GatherRick: The older versions didn't keep styles like color either so the new release is no different from the old one in that regard.

This statement confuses me a bit. As a test in Word 2003 I created a bulletted list with different fonts and colors. Then when I paste this list into TinyMCE the following HTML is inserted (Notice that both the color and font information are preserved):

<p> </p>
<ul style="MARGIN-TOP: 0in" type="disc">
<li style="COLOR: lime; mso-list: l0 level1 lfo1; tab-stops: list .5in"><em style="mso-bidi-font-style: normal">This is some text from word</em>. </li>
<li style="COLOR: lime; mso-list: l0 level1 lfo1; tab-stops: list .5in"><strong style="mso-bidi-font-weight: normal">Here is some more test.</strong></li>
<li style="COLOR: #ff9900; mso-list: l0 level1 lfo1; tab-stops: list .5in"><strong style="mso-bidi-font-weight: normal"><span style="FONT-SIZE: 18pt; FONT-FAMILY: 'Bauhaus 93'; mso-bidi-font-size: 12.0pt">A different font and color.</span></strong></li>
</ul>
<p><span style="COLOR: lime"> </span></p>
<ul style="MARGIN-TOP: 0in" type="disc">
<li style="COLOR: lime; mso-list: l0 level1 lfo1; tab-stops: list .5in"><span style="COLOR: #ffcc00">Bl</span><span style="COLOR: #ff6600">ah</span>.</li>
</ul>

38

Re: TinyMCE 3.2.3 Released

This is using release 3.2.1 of TinyMCE BTW.

39

Re: TinyMCE 3.2.3 Released

Upgrade to the latest version. It won't preserve that contents. The 3.2.3 has a new rewritten paste/word cleanup plugin.

Best regards,
Spocke - Main developer of TinyMCE

40

Re: TinyMCE 3.2.3 Released

I may have been doing this wrong the whole time, but in Safari 4 Beta and the latest nightly, manually focusing the editor like so:

tinyMCE.execInstanceCommand(tmce, focus());
(where tmce is the editor)

raises an error: TypeError: Result of expression 'j' [undefined] is not an object. in tiny_mce.js


This had not worked in IE, and now it doesn't work in the latest Safaris. Using 3.2.2, this works fine in Safari. If this is a regression, should I submit a bug report or am I simply doin' it wrong? tongue

Thanks much,
Nathan

Last edited by Zaragosa (2009-04-28 20:34:18)

41

Re: TinyMCE 3.2.3 Released

File a bug report and steps for us to reproduce it if you think it's a bug.

Best regards,
Spocke - Main developer of TinyMCE

42

Re: TinyMCE 3.2.3 Released

spocke wrote:

We didn't want to support the old paste plugin since it had some issues with Word 2007 that didn't exist when we created it. So we just removed the old one and replaced it with the new one. It's still missing some options and features that the old one had, we will look into adding them over time.

I have just posted a patch (https://sourceforge.net/tracker/?func=d … tid=635684) to restore some of the removed functionality.  At present this is conflicting with middot/list conversion - I am hoping you might spot the problem with this quicker than me.

Cheers,

Scott

(a.k.a. monkeybrain)

43

Re: TinyMCE 3.2.3 Released

This is excellent work. I guess the conflict with the middot/list conversion is due to that logic excepts the paragraphs to be empty from spans but since the spans are keept intact it will fail. But that's just a guess haven't fiddled with your code yet.

Best regards,
Spocke - Main developer of TinyMCE

44

Re: TinyMCE 3.2.3 Released

spocke wrote:

This is excellent work. I guess the conflict with the middot/list conversion is due to that logic excepts the paragraphs to be empty from spans but since the spans are keept intact it will fail. But that's just a guess haven't fiddled with your code yet.

Glad that you like it.  I found a comma in my code that caused an error - I will post a revised patch shortly.

Speaking of the middot/list conversion, with a fairly trivial two level indented unordered list copied from Word 2007 I get a different result when I do a Ctrl-v vs using the pasteword window.  This is happening on the full featured example page on the TinyMCE site.

Here is the correct result (produced using pasteword - the indentation is mine):

<p>A list:</p>
<ul>
    <li>Item 1 
        <ul>
            <li>Item 1.1</li>
        </ul>
    </li>
    <li>Item 2</li>
</ul>

and here is the incorrect result (produced using Ctrl-v - indentation is mine):

<p>A list:</p>
<ul>
    <li>Item 1 
        <ul>
            <li>Item 1.1</li>
            <li>Item 2</li>
        </ul>
    </li>
</ul>

Creating the Word file is trivial - use the first example above as your guide.  To reproduce the problem you also need to copy the paragraph that precedes the list.

Also, could the body element of the iframe used for the pasteword window have class="mceContentBody" applied to it?  My pasteword window is picking up a body style that has text-align:center rather than a body.mceContentBody rule that has text-align:left - here is the patch (I know this is not the place):

Index: jscripts/tiny_mce/plugins/paste/js/pasteword.js
===================================================================
--- jscripts/tiny_mce/plugins/paste/js/pasteword.js    (revision 1111)
+++ jscripts/tiny_mce/plugins/paste/js/pasteword.js    (working copy)
@@ -18,7 +18,7 @@
 
         // Write content into iframe
         doc.open();
-        doc.write('<html><head>' + cssHTML + '</head><body spellcheck="false"></body></html>');
+        doc.write('<html><head>' + cssHTML + '</head><body class="mceContentBody" spellcheck="false"></body></html>');
         doc.close();
 
         doc.designMode = 'on';

Now back to some other things for me.

Scott

(a.k.a. monkeybrain)

45

Re: TinyMCE 3.2.3 Released

TinyMCE 3.2.3 has an issue with the new Paste selecting a single character either BEFORE or AFTER the insertion point and replacing it with the pasted text. Does not affect Paste if there is an active selection.

Spocke has already fixed this in the SVN code repository... It's a one line addition... Line 368 in /plugins/paste/editor_plugin_src.js : if (!ed.selection.isCollapsed())

We've added this line, recompressed, and tested, and now plan to release to our users on 2 May 2009. Thanks!

BTW, we've also added jquery calls to dynamically add code to textareas in our email marketing templates, allowing TinyMCE to load onFocus(), eliminating our need for Ask mode.

All the best,

Pepi Acebo

http://www.mynewsletterbuilder.com

Last edited by Pepi (2009-05-01 15:10:53)

46

Re: TinyMCE 3.2.3 Released

Strange, after installing tinymce 3.2.3, the inline popups didn't show any content in Firefox 3. I found out that all the popup windows html of the plugins (for example link.htm, table.htm)  have a body tag with style=display:none in it. Removing this style solved the problem. Is this a known issue?

47

Re: TinyMCE 3.2.3 Released

RobF wrote:

Strange, after installing tinymce 3.2.3, the inline popups didn't show any content in Firefox 3. I found out that all the popup windows html of the plugins (for example link.htm, table.htm)  have a body tag with style=display:none in it. Removing this style solved the problem. Is this a known issue?

We're not seeing this with our users. We're using inline popups.

Suggest testing using the examples on this site.

All the best,

Pepi Acebo

http://www.mynewsletterbuilder.com

Last edited by Pepi (2009-05-05 15:45:17)